Bug 368311: Add a new warning during fetching git repo
ClosedPublic

Authored by nellex on Jan 4 2017, 7:10 PM.

Details

Summary

Addressed the bug: 368311 (https://bugs.kde.org/show_bug.cgi?id=368311)

Improved the warning message showed during fetching a git repo if the specified folder is empty.

Test Plan

Tested working for all possible cases while fetching a repo from git or Bazaar.

Diff Detail

Repository
R33 KDevPlatform
Branch
BugFix-368311 (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
nellex updated this revision to Diff 9726.Jan 4 2017, 7:10 PM
nellex retitled this revision from to Inital patch for bug: 368311.
nellex updated this object.
nellex edited the test plan for this revision. (Show Details)
nellex added a reviewer: kfunk.
Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptJan 4 2017, 7:10 PM
nellex retitled this revision from Inital patch for bug: 368311 to Bug 368311: Add a new warning during fetching git repo.Jan 4 2017, 7:12 PM
nellex added a reviewer: KDevelop.
kfunk requested changes to this revision.Jan 4 2017, 7:23 PM
kfunk edited edge metadata.
kfunk added inline comments.
shell/projectsourcepage.cpp
225–226

Same here, fwiw. Could you change that as well?

230

Could be initialized properly in one expression (no need for another if-statement)

This revision now requires changes to proceed.Jan 4 2017, 7:23 PM
nellex updated this revision to Diff 9729.Jan 4 2017, 9:20 PM
nellex edited edge metadata.
  • Minor fixes
kfunk added a comment.Jan 5 2017, 12:57 AM

Rest LGTM

shell/projectsourcepage.cpp
226

This doesn't need a ternary operation :)

Hint: a ? b : false => a && b

kfunk requested changes to this revision.Jan 5 2017, 12:57 AM
kfunk edited edge metadata.
This revision now requires changes to proceed.Jan 5 2017, 12:57 AM
kfunk added a comment.Jan 5 2017, 1:03 AM

I'll fix myself & push

nellex updated this revision to Diff 9769.Jan 5 2017, 4:34 PM
nellex edited edge metadata.
  • Minor fixes
This revision was automatically updated to reflect the committed changes.
kfunk added a comment.Jan 8 2017, 12:03 PM

Note: Please configure Git to use a full name as author name.

Couldn't push your patch initially:

remote: Audit failure - Commit ef94a0fa01f0d8cc148c7b332724dfd57fbb45c4 - Non-full name: Nilesh
remote: FATAL: VREF/kde-update-checks: helper program exit status 256
remote: Push declined - commits failed audit
remote: error: hook declined to update refs/heads/master

Fixed & pushed now. Thanks for the patch!