More unit tests and fixes for lldb formatters
ClosedPublic
Actions

Authored by qi437103 on Jan 3 2017, 10:49 PM.

Details

Reviewers

apol
kfunk

Group Reviewers

KDevelop

Commits

R32:cdf2ec8b7ce7: More unit tests and fixes for lldb formatters

Summary

The lldb formatters were left without much tests in the summer. I finally got some time to cover more cases.

Added and fixed tests are

QString and QByteArray are displayed with correct escaping and can handle unicode contents
QList, QVector, QQueue, QStack, QLinkedList
QDate, QTime and QDateTime
QMap, QHash, QSet
QUrl, QUuid
KDE types

Diff Detail

Repository

R32 KDevelop

Branch

lldb-formatters

Lint

No Linters Available

Unit

No Unit Test Coverage

qi437103 updated this revision to Diff 9675.Jan 3 2017, 10:49 PM

qi437103 retitled this revision from to [WIP] Adding more unit tests for lldb formatters.

qi437103 updated this object.

qi437103 edited the test plan for this revision. (Show Details)

qi437103 added a reviewer: kfunk.

Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptJan 3 2017, 10:49 PM

qi437103 added a reviewer: KDevelop.Jan 3 2017, 10:50 PM

qi437103 retitled this revision from [WIP] Adding more unit tests for lldb formatters to [WIP] More unit tests and fixes for lldb formatters.

Something for @apol to review I suppose.

@qi437103: Should this patch go into 5.1 branch?

@kfunk yes I think so, it's just bug fixes, and for a better first time impression people get about the LLDB plugin with the 5.1 release. I'll rebase.

Rebased on 5.1

kfunk added a reviewer: apol.Jan 4 2017, 7:24 PM

Added and fixed remaining test cases, and rebased to latest HEAD.

It's now ready for review.

I'd put it in 5.1, since it's bug fixes.

This revision is now accepted and ready to land.Jan 5 2017, 1:18 PM

qi437103 closed this revision.Jan 5 2017, 7:42 PM

Revision Contents
Changeset List

			Path	Packages
M			debuggers/lldb/TODO.txt (7 lines)
M			debuggers/lldb/controllers/variable.cpp (8 lines)
M			debuggers/lldb/controllers/variablecontroller.cpp (6 lines)
M			debuggers/lldb/formatters/helpers.py (45 lines)
M			debuggers/lldb/formatters/kde.py (5 lines)
M			debuggers/lldb/formatters/qt.py (298 lines)
M			debuggers/lldb/unittests/debugees/debugeeqt.cpp (1 line)
M			debuggers/lldb/unittests/debugees/qbytearray.cpp (2 lines)
M			debuggers/lldb/unittests/debugees/qstring.cpp (2 lines)
M			debuggers/lldb/unittests/test_lldb.h (1 line)
M			debuggers/lldb/unittests/test_lldb.cpp (20 lines)
M			debuggers/lldb/unittests/test_lldbformatters.h (30 lines)
M			debuggers/lldb/unittests/test_lldbformatters.cpp (1014 lines)
M			debuggers/lldb/unittests/testhelper.h (2 lines)
M			debuggers/lldb/unittests/testhelper.cpp (12 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	9675	4f5ef69		Jan 3 2017, 10:49 PM	★	★
Diff 2	9678	22b1289	Rebased on 5.1	Jan 3 2017, 11:30 PM	★	★
Diff 3	9733	fe1a940	Added and fixed remaining test cases, and rebased to latest HEAD.	Jan 4 2017, 10:19 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
8c91c3c872aa	ee0b33bd5153	e8cd9844f2f6	Peifeng Yu	Add and fix remaining lldb formatter tests (Show More…)	Jan 4 2017, 10:08 PM
e8cd9844f2f6	6fd50660a377	b6736d7ad49c	Peifeng Yu	Fix lldb formatting when qDebug presents	Jan 2 2017, 10:54 AM
b6736d7ad49c	30352a6b3e64	fbc18c080020	Peifeng Yu	Add lldb formatter unit tests for container types	Jan 3 2017, 10:29 PM
fbc18c080020	5156b19ee38b	3b7257ca1e34	Peifeng Yu	Fix sometimes watches/local variables are not updated when using lldb	Jan 3 2017, 10:27 PM
3b7257ca1e34	cb9763055b65	fb85b79274ff	Peifeng Yu	Remove duplicated test, it's covered more thoroughly in lldbformatters tests	Jan 3 2017, 10:29 PM
fb85b79274ff	b469d3918d34	ef8a19a4b230	Peifeng Yu	Add fix lldb formatter unit test for QByteArray	Dec 31 2016, 6:39 AM
ef8a19a4b230	c06dc16a22f9	fe1a940bf127	Peifeng Yu	Code style fix	Dec 31 2016, 3:44 AM