VFS: cleaner code for refresh check on vfs operation without current directory
ClosedPublic

Authored by abika on Jan 3 2017, 7:37 PM.

Details

Summary

Rework of filesystem info and space update after refresh and file operation. Part of cleaning VFS
BUG: 374404

VFS: cleaning inheritance issues with VFS classes. Part of cleaning VFS


The bug report https://bugs.kde.org/show_bug.cgi?id=374404 made me notice some flaws with the current file space refresh. I couldn't help myself and changed most of the code.

Behaviour changes:

  • free space update should work now flawless. I.e. if changes to the filesystem space are made inside Krusader all panels (and tabs) showing the same filesystem are updated
  • no special label for /etc and /proc anymore. I feel its fine to show "0 of of 0 bytes" here. And /sys was missing anyway.
  • "Virtual Filesystem" is shown now if "virt_fs" is used (and no search meta information is present).
Test Plan

Checked panels filesystem stats update in both panels (+tabs) when

  • copying file on local fs with {F5/copy, drag&drop, copy/paste}
  • deleting file on local fs
  • creating virtual directory from search result ("feed to listbox")
  • changing directory/refreshing to different fs

Diff Detail

Repository
R167 Krusader
Branch
my-filesystem_stats
Lint
No Linters Available
Unit
No Unit Test Coverage
abika updated this revision to Diff 9666.Jan 3 2017, 7:37 PM
abika retitled this revision from to VFS: cleaner code for refresh check on vfs operation without current directory.
abika updated this object.
abika edited the test plan for this revision. (Show Details)
abika added a reviewer: Krusader.
abika updated this object.Jan 3 2017, 7:45 PM
martinkostolny accepted this revision.Jan 3 2017, 10:06 PM
martinkostolny added a reviewer: martinkostolny.
martinkostolny added a subscriber: martinkostolny.

Working nicely, thanks for the rework!

This revision is now accepted and ready to land.Jan 3 2017, 10:06 PM
asensi added a subscriber: asensi.Jan 4 2017, 10:30 AM

The source code gets compiled using Kubuntu 16.04, the free space information gets updated after a copy of a big file, and also Krusader seems to work correctly browsing folders and compressed archives. Thanks, Alex and everyone!

asensi accepted this revision.Jan 4 2017, 10:30 AM
asensi added a reviewer: asensi.
abika closed this revision.Jan 4 2017, 3:39 PM

Thanks!

And sorry for the terrible long commit messages. arc is still driving me nuts. Automatic merge and commit messages I totally don't want but somehow no automatic differential closing with --merge.

I think I will switch to pure git merging instead of arc land.