When in folder view(placed in panel) location is set to Desktop(desktop:/), clicking on a *.desktop file with Type=Link should change to the pointed directory (this is what FolderView tries to do).
Now in this context FolderModel::isDir, as expected, returns true but since FolderModel::cd uses KFileItem::isDir, it evaluates to false and directory is not changed.
So using IsDirRole in place of KFileItem::isDir can resolve this conflict.
Details
Details
- Reviewers
hein - Group Reviewers
Plasma - Commits
- R119:23cff2bf3521: [Folder View] Fix CD in "Link" type desktop files
Before Applying patch:
Set location to 'desktop:/'
Clicked on 'Home'
Nothing happened (neither cd nor dolphin opened)
After patch:
Set location to desktop:/
Clicked on Home
Directory changed in place and contents of home directory shown.
Diff Detail
Diff Detail
- Repository
- R119 Plasma Desktop
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.