[DolphinView] Update view palette on palette change
ClosedPublic

Authored by broulik on Jan 1 2017, 4:31 PM.

Details

Summary

Everything was handling palette change already but for the visual distinction between active and non-active view (in case of split view), a custom palette was set which was then never updated. This could be seen by the label text color changing but not the view background.

BUG:

Test Plan

Changed from Breeze and Breeze Dark and vice-versa and Dolphin's file view picked it up immediately, both in split and single view mode. Also verified that the active and inactive view are still visually distinct

(I bet there is a bug report about this but I cant find one right now)

Diff Detail

Repository
R318 Dolphin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik updated this revision to Diff 9585.Jan 1 2017, 4:31 PM
broulik retitled this revision from to [DolphinView] Update view palette on palette change.
broulik updated this object.
broulik edited the test plan for this revision. (Show Details)
broulik added reviewers: Dolphin, emmanuelp.
broulik set the repository for this revision to R318 Dolphin.
emmanuelp accepted this revision.Jan 1 2017, 6:16 PM
emmanuelp edited edge metadata.
This revision is now accepted and ready to land.Jan 1 2017, 6:16 PM
This revision was automatically updated to reflect the committed changes.
cfeck added a subscriber: cfeck.Jan 3 2017, 1:42 PM

Does it fix bug 335175?