MediaController: Stop queuedPositionUpdate timer when receiving mpris position change
ClosedPublic

Authored by drosca on Jan 1 2017, 3:37 PM.

Details

Summary

Fixes sometimes reseting position to 0 after expanding applet.

Test Plan

No longer resets to start of song after showing applet

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
drosca retitled this revision from to MediaController: Stop queuedPositionUpdate timer when receiving mpris position change.Jan 1 2017, 3:37 PM
drosca updated this object.
drosca edited the test plan for this revision. (Show Details)
drosca added reviewers: Plasma, broulik.
Restricted Application added a project: Plasma. · View Herald TranscriptJan 1 2017, 3:37 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik accepted this revision.Jan 1 2017, 3:44 PM
This revision is now accepted and ready to land.Jan 1 2017, 3:44 PM
drosca added a comment.Jan 1 2017, 3:48 PM

It's wrong, sorry. Removing the timer.running check from if is correct, but stopping it is not. In that state, it now fixes issue with seeking to 0 but it still seeks to *current* position - so you may hear pause in the playing song.

drosca updated this revision to Diff 9581.Jan 1 2017, 3:52 PM

Also don't call SetPosition when slider value equals position

This revision was automatically updated to reflect the committed changes.