Applet: Don't delete delegates while drag is active
ClosedPublic

Authored by drosca on Jan 1 2017, 10:11 AM.

Details

Summary

BUG: 374288

Test Plan

No crash, delegates are still correctly deleted

Diff Detail

Repository
R115 Plasma Audio Volume Applet
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
drosca retitled this revision from to Applet: Don't delete delegates while drag is active.Jan 1 2017, 10:11 AM
drosca updated this object.
drosca edited the test plan for this revision. (Show Details)
drosca added a reviewer: Plasma.
Restricted Application added a project: Plasma. · View Herald TranscriptJan 1 2017, 10:11 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson accepted this revision.Jan 1 2017, 7:54 PM
davidedmundson added a reviewer: davidedmundson.
davidedmundson added a subscriber: davidedmundson.

That's clever, we could do with a similar fix in kicker somewhere.

This revision is now accepted and ready to land.Jan 1 2017, 7:54 PM
This revision was automatically updated to reflect the committed changes.
hein added a subscriber: hein.Jan 2 2017, 8:15 AM

(Just for the record: Applets like Task Manager, Folder View and Kicker-based launchers instead use a helper QObject class to instanciate QDrag and parent it to the applet itself.)