Fix build warnings and clear up init() code for items
ClosedPublic
Actions

Authored by piggz on Dec 31 2016, 4:54 PM.

Details

Reviewers

staniek

Commits

Summary

Minor changes to remove all build warnings

Test Plan

Run kreportexample

Repository

R14 KReport

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

piggz retitled this revision from to Fix build warnings and clear up init() code for items.

piggz updated this object.

piggz edited the test plan for this revision. (Show Details)

piggz added a reviewer: staniek.

Perfect.

src/common/KReportElement.cpp
46	Just curious, what warning was here?

This revision is now accepted and ready to land.Jan 2 2017, 9:01 PM

piggz marked an inline comment as done.Jan 2 2017, 9:11 PM

piggz added inline comments.

src/common/KReportElement.cpp
46	/home/piggz/src/kreport/src/common/KReportElement.cpp: In function ‘uint qHash(const KReportElement&, uint)’: /home/piggz/src/kreport/src/common/KReportElement.cpp:46:21: warning: declaration of ‘uint qHash(const KReportElement&, uint)’ has a different exception specifier [-Wpedantic] KREPORT_EXPORT uint qHash(const KReportElement &element, uint seed) ^~~~~ In file included from /home/piggz/src/kreport/src/common/KReportElement.cpp:20:0: /home/piggz/src/kreport-build/src/KReportElement.h:229:21: note: from previous declaration ‘uint qHash(const KReportElement&, uint) noexcept’ KREPORT_EXPORT uint qHash(const KReportElement &element, uint seed = 0) Q_DECL_NOTHROW;

This revision was automatically updated to reflect the committed changes.

piggz marked an inline comment as done.

src/common/KReportElement.cpp
46	Fixing it now... declaration in KReportElement.h had Q_DECL_NOTHROW, definition should have it too.

			Path	Packages
M			src/common/KReportDocument.cpp (4 lines)
M			src/common/KReportElement.cpp (2 lines)
M			src/common/KReportItemBase.cpp (2 lines)
M			src/items/check/KReportDesignerItemCheckBox.h (2 lines)
M			src/items/check/KReportDesignerItemCheckBox.cpp (6 lines)
M			src/items/field/KReportDesignerItemField.h (2 lines)
M			src/items/field/KReportDesignerItemField.cpp (8 lines)
M			src/items/image/KReportDesignerItemImage.h (2 lines)
M			src/items/image/KReportDesignerItemImage.cpp (8 lines)
M			src/items/label/KReportDesignerItemLabel.h (2 lines)
M			src/items/label/KReportDesignerItemLabel.cpp (6 lines)
M			src/items/text/KReportDesignerItemText.h (2 lines)
M			src/items/text/KReportDesignerItemText.cpp (8 lines)
M			src/plugins/barcode/KReportDesignerItemBarcode.h (2 lines)
M			src/plugins/barcode/KReportDesignerItemBarcode.cpp (6 lines)
M			src/plugins/maps/KReportDesignerItemMaps.h (2 lines)
M			src/plugins/maps/KReportDesignerItemMaps.cpp (10 lines)
M			src/plugins/web/KReportDesignerItemWeb.h (4 lines)
M			src/plugins/web/KReportDesignerItemWeb.cpp (6 lines)