KDateCombo still uses KLocale and blocks waiting for a DBus reply of ktimezoned which never arrives.
This class is now available in modernized form in KWidgetsAddons, so drop our own outdated copy.
Details
Details
- Reviewers
dfaure - Commits
- R228:76458d222f8b: Port to KDateComboBox of KWidgetsAddons
KFind starts instantly again.
Other than that selecting a date range works, complaining if it's in the future or invalid, finding different results depending on the criteria. (It still starts the search after having complained about invalid dates but that is also without this patch, needs to be addressed separately)
Diff Detail
Diff Detail
- Repository
- R228 KFind
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
- Use KDateComboBox in KWidgetsAddons and drop own copy
Just found this class :) It also has nifty shortcuts for "today", "last week", and also shows the full year.
Comment Actions
Looks good.
Interesting, I can't approve again in the GUI, it says my previous approval is still valid ;). This doesn't work like gerrit where any new patch being uploaded discards previous approvals.