Some random corrections
ClosedPublic

Authored by patrickelectric on Dec 30 2016, 7:32 PM.

Details

Reviewers
brauch
Group Reviewers
KDevelop
Commits
R32:4f5ef69b9dca: Some random corrections

Diff Detail

Repository
R32 KDevelop
Branch
main
Lint
No Linters Available
Unit
No Unit Test Coverage
patrickelectric retitled this revision from to Less Code Make Tomaz Happy.
patrickelectric updated this object.
patrickelectric edited the test plan for this revision. (Show Details)
Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptDec 30 2016, 7:32 PM

Some corrections in main.cpp

corrections in KDevelopSessionsEngine

brauch requested changes to this revision.Dec 30 2016, 7:49 PM
brauch added a reviewer: brauch.
brauch added a subscriber: brauch.
brauch added inline comments.
app/plasma/dataengine/kdevelopsessionsengine.cpp
40 ↗(On Diff #9514)

KDirWatch looks like a QObject, do you really need to delete it?

45 ↗(On Diff #9514)

Does this ever happen?

documentation/qthelp/tests/test_qthelpplugin.cpp
44 ↗(On Diff #9514)

use the
foo()
: m_foo(...)
, m_bar(...)

formatting please

projectbuilders/qmakebuilder/qmakejob.cpp
41 ↗(On Diff #9514)

as above

This revision now requires changes to proceed.Dec 30 2016, 7:49 PM
patrickelectric edited edge metadata.

Style corrections and remove some deletes

brauch accepted this revision.Dec 30 2016, 7:57 PM
brauch edited edge metadata.

Looks ok, thanks.

This revision is now accepted and ready to land.Dec 30 2016, 7:57 PM
patrickelectric marked an inline comment as done.
patrickelectric edited edge metadata.

style corrections

patrickelectric marked an inline comment as done.Dec 30 2016, 7:59 PM

Style corrections done.

patrickelectric retitled this revision from Less Code Make Tomaz Happy to Some random corrections.Dec 30 2016, 8:02 PM
patrickelectric updated this object.
This revision was automatically updated to reflect the committed changes.