Diff Detail
- Lint
Lint Skipped - Unit
Unit Tests Skipped
I replaced CheckBox by a QPushButton for sending certificate to server (I need to find method to do it now)
I added title in dialog.
I fixed layout.
I reenabled "More details button" when we close dialog.
I save/load dialog size.
I think you created a new review instead of updating https://phabricator.kde.org/D3584
"I think you created a new review instead of updating https://phabricator.kde.org/D3584" yep I know but I never able to update current D3584. I don't know why.
@mlaurent I have merged your changes + added some of mine back to D3584.
Unfortunately you can't update a review you don't own in Phabricator, but you can select "Commandeer Revision" Action which will transfer the ownership of the review to you, then you can update it. I'll then "Commandeer" the revision back to me when I need to update it again.