Use new xkbcommon API for consumed modifiers
ClosedPublic

Authored by graesslin on Dec 26 2016, 11:00 AM.

Details

Summary

This change removes the workaround added with
421824b654a5301fe1c0ed97caded66936c91385.

Xkbcommon 0.7 introduces the needed API to make this work without a
workaround.

Test Plan

Test case still passes

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
graesslin updated this revision to Diff 9363.Dec 26 2016, 11:00 AM
graesslin retitled this revision from to Use new xkbcommon API for consumed modifiers.
graesslin updated this object.
graesslin edited the test plan for this revision. (Show Details)
graesslin added reviewers: KWin, Plasma on Wayland.
Restricted Application added projects: Plasma on Wayland, KWin. · View Herald TranscriptDec 26 2016, 11:00 AM
Restricted Application added subscribers: kwin, plasma-devel. · View Herald Transcript
sebas accepted this revision.Dec 27 2016, 4:35 PM
sebas added a reviewer: sebas.
This revision is now accepted and ready to land.Dec 27 2016, 4:35 PM
This revision was automatically updated to reflect the committed changes.
kfunk added a subscriber: kfunk.EditedDec 29 2016, 4:00 PM

This patch makes it impossible to build kwin on Ubuntu 16.10 (latest Ubuntu release) against distro libxkbcommon package -- isn't it possible to stay compatible with XKB 0.5.0 for some more time?

Note: looks like libxkbcommon-0.7.0 was released 2016-11-11, so just one month ago.

In D3809#72177, @kfunk wrote:

This patch makes it impossible to build kwin on Ubuntu 16.10 (latest Ubuntu release) against distro libxkbcommon package -- isn't it possible to stay compatible with XKB 0.5.0 for some more time?

No it's not. Do you think I'm not aware of the fact that this will create a hassle?

Note: looks like libxkbcommon-0.7.0 was released 2016-11-11, so just one month ago.

Yes I know exactly when it was released. It was released also because *I* requested it.

kfunk added a comment.Dec 30 2016, 8:25 AM
In D3809#72177, @kfunk wrote:

This patch makes it impossible to build kwin on Ubuntu 16.10 (latest Ubuntu release) against distro libxkbcommon package -- isn't it possible to stay compatible with XKB 0.5.0 for some more time?

No it's not. Do you think I'm not aware of the fact that this will create a hassle?

Well, I was surprised to see the version bump for this seemingly trivial change, thus I asked. Is it not possible to conditionally compile in some code based on the XKB version instead? "No it's not" isn't a satisfying explanation.

I'm asking because I see more and more code bases in KDE requiring too-bleeding-edge software (hint: our kdepim stack), with all the consequences this has -- of which you're surely aware of.

Note: looks like libxkbcommon-0.7.0 was released 2016-11-11, so just one month ago.

Yes I know exactly when it was released. It was released also because *I* requested it.

In D3809#72177, @kfunk wrote:

This patch makes it impossible to build kwin on Ubuntu 16.10 (latest Ubuntu release) against distro libxkbcommon package -- isn't it possible to stay compatible with XKB 0.5.0 for some more time?

No it's not. Do you think I'm not aware of the fact that this will create a hassle?

Note: looks like libxkbcommon-0.7.0 was released 2016-11-11, so just one month ago.

Yes I know exactly when it was released. It was released also because *I* requested it.

could I ask you a favor? Please trust the maintainer. If I write no it's not possible then I mean that. This is the knowledge only core devs can have. To you it looks like a trivial change. To me it is a very important bug fix which had weeks of preparations.

This includes creating a bug report against neon that they package it. Checking with opensuse devs whether it is in tumbleweed. Waiting till it hits Debian testing. And at the same time ensuring it goes in before the dep freeze.

Yes I know it is annoying. Also for me. Build.kde.org is red. But ifdef is in this case no option.

could I ask you a favor? Please trust the maintainer. If I write no it's not possible then I mean that. This is the knowledge only core devs can have. To you it looks like a trivial change. To me it is a very important bug fix which had weeks of preparations.

This includes creating a bug report against neon that they package it. Checking with opensuse devs whether it is in tumbleweed. Waiting till it hits Debian testing. And at the same time ensuring it goes in before the dep freeze.

Yes I know it is annoying. Also for me. Build.kde.org is red. But ifdef is in this case no option.

Okay, thanks for explaining. Just wanted to make sure we're not bumping requirements fleet-footed -- I trust you there's no other option (I don't enough have insight into kwin/XKB to judge) -- thanks!