Simplified transition between different views
ClosedPublic
Actions

Authored by anthonyfieroni on Dec 23 2016, 3:32 PM.

Details

Reviewers

Test Plan

Play video file -> videoview -> wait to auto end -> loadview
Play video file -> videoview -> press stop -> loadview
Play video file -> videoview -> press Play media (preview) -> wait to end -> loadview
Play video file -> videoview -> press Play media (preview) -> press stop -> loadview

Play audio file -> audioview -> wait to auto end -> loadview
Play audio file -> audioview -> press stop -> loadview
Play audio file -> audioview -> press Play media -> wait to end -> loadview
Play audio file -> audioview -> press Play media -> press stop -> loadview

Play video file -> press Play Media -> press Play file / dvd / stream -> thumbnail is hide

Diff Detail

Lint

Lint Skipped

Unit

Unit Tests Skipped

anthonyfieroni updated this revision to Diff 9340.Dec 23 2016, 3:32 PM

anthonyfieroni retitled this revision from to Simplified transition between different views.

anthonyfieroni updated this object.

anthonyfieroni edited the test plan for this revision. (Show Details)

anthonyfieroni added a reviewer: sitter.

anthonyfieroni added a subscriber: sitter.

anthonyfieroni retitled this revision from Simplified transition between different views to [dragon] Simplified transition between different views.Dec 23 2016, 3:43 PM

anthonyfieroni updated this revision to Diff 9342.Dec 23 2016, 4:03 PM

anthonyfieroni changed the visibility from "All Users" to "Public (No Login Required)".

(unrelated note: if you need a repository which is not yet in Phabricator, please ping the Community Admins or the sysadmins)

ltoscano removed a subscriber: ltoscano.Dec 23 2016, 9:40 PM

ping

For future reference. When you touch a file or add a new one please use the framworks coding style [1] over time more and more could would that way move away from the horrendous style it uses now. ;)

[1] https://techbase.kde.org/Policies/Frameworks_Coding_Style

This revision is now accepted and ready to land.Jan 2 2017, 11:10 AM

anthonyfieroni closed this revision.Jan 2 2017, 1:55 PM

This causes a regression, see https://bugs.kde.org/show_bug.cgi?id=381282

There is code that does "m_mainView->addWidget(m_currentWidget);" but m_currentWidget is nowhere initialized to a non-null value.

Oh, I see there is new code in stateChange.cpp, but that does not seem to work when opening broken files.

Yeah, the class is spread over like 3 files -.-

Probably just needs a null check there TBH.

Revision Contents
Changeset List

			Path	Packages
M			src/app/loadView.cpp (5 lines)
M			src/app/mainWindow.cpp (52 lines)
M			src/app/stateChange.cpp (13 lines)
M			src/app/videoWindow.h (1 line)
M			src/app/videoWindow.cpp (2 lines)