Turn flawed "QTestLib with KDE" template into "Test Suite for GUI-less code"
AbandonedPublic

Authored by kossebau on Dec 22 2016, 1:00 AM.

Details

Reviewers
kfunk
Group Reviewers
KDevelop
Summary

There was nothing "KDE" more in it
Also was missing Q_OBJECT macro and the include of QTest

Diff Detail

Repository
R32 KDevelop
Branch
renameKDEQTestToGuiLess
Lint
No Linters Available
Unit
No Unit Test Coverage
kossebau updated this revision to Diff 9282.Dec 22 2016, 1:00 AM
kossebau retitled this revision from to Turn flawed "QTestLib with KDE" template into "Test Suite for GUI-less code".
kossebau updated this object.
kossebau added a reviewer: KDevelop.
Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptDec 22 2016, 1:00 AM

Not sure if such a separate template makes sense, which differs from cpp_qtestlib only by s/QTEST_MAIN/QTEST_GUILESS_MAIN/.

Though for convenience it might make sense, also for promoting the option perhaps.
Just discovered there is also a QTEST_APPLESS_MAIN...

Perhaps there could be just cpp_qtestlib and a comment in the line above QTEST_MAIN:

// other options: QTEST_GUILESS_MAIN, QTEST_APPLESS_MAIN
QTEST_MAIN({{ name }});
kfunk accepted this revision.Dec 22 2016, 1:07 AM
kfunk added a reviewer: kfunk.
This revision is now accepted and ready to land.Dec 22 2016, 1:07 AM
kfunk added a comment.Dec 22 2016, 1:09 AM

Not sure if such a separate template makes sense, which differs from cpp_qtestlib only by s/QTEST_MAIN/QTEST_GUILESS_MAIN/.

Though for convenience it might make sense, also for promoting the option perhaps.
Just discovered there is also a QTEST_APPLESS_MAIN...

Perhaps there could be just cpp_qtestlib and a comment in the line above QTEST_MAIN:

// other options: QTEST_GUILESS_MAIN, QTEST_APPLESS_MAIN
QTEST_MAIN({{ name }});

Actually, yep, I like that better.

QTEST_MAIN() is probably the most common, so that should be the default.

kfunk requested changes to this revision.Dec 22 2016, 1:09 AM
kfunk edited edge metadata.
This revision now requires changes to proceed.Dec 22 2016, 1:09 AM
kossebau abandoned this revision.Dec 22 2016, 1:18 AM

So discarding this one as discussed on irc, and simply only removing cpp_qtestlib_kde and adding that comment to cpp_qtestlib.