Add an app_template for a simple KDevelop plugin
ClosedPublic

Authored by kossebau on Dec 22 2016, 12:11 AM.

Details

Summary

To allow the quick start of a new KDevelop plugin

Diff Detail

Repository
R32 KDevelop
Branch
addKDevPluginTemplate
Lint
No Linters Available
Unit
No Unit Test Coverage
kossebau updated this revision to Diff 9280.Dec 22 2016, 12:11 AM
kossebau retitled this revision from to Add an app_template for a simple KDevelop plugin.
kossebau updated this object.
kossebau added a reviewer: KDevelop.
Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptDec 22 2016, 12:11 AM
kfunk accepted this revision.Dec 22 2016, 12:58 AM
kfunk added a reviewer: kfunk.
kfunk added a subscriber: kfunk.

Rest LGTM, great!

app_templates/cpp/CMake/cmake_kdevplugin/README
1 ↗(On Diff #9280)

Turn into a README.md (Markdown syntax) maybe? Way more common these days.

23 ↗(On Diff #9280)

"... check the output of make install to see where the plugin is installed" maybe?

app_templates/cpp/CMake/cmake_kdevplugin/src/%{APPNAMELC}.cpp
6 ↗(On Diff #9280)

Style: Add newline before, remove after

This revision is now accepted and ready to land.Dec 22 2016, 12:58 AM
kossebau added inline comments.Dec 22 2016, 1:10 AM
app_templates/cpp/CMake/cmake_kdevplugin/README
23 ↗(On Diff #9280)

This was written with building from KDevelop UI ;) So make install might be too console-centric?

kossebau updated this revision to Diff 9283.Dec 22 2016, 1:36 AM
kossebau marked 2 inline comments as done.
kossebau edited edge metadata.

README->README.md, style fixes

nalvarez added inline comments.
app_templates/cpp/CMake/cmake_kdevplugin/README
17 ↗(On Diff #9280)

add → and?

35 ↗(On Diff #9280)

"and it also listed in" doesn't seem to make grammatical sense. How about "you should see ... printed in the console and the plugin listed in the dialog..."?

kossebau marked an inline comment as done.Dec 22 2016, 10:53 AM
kossebau added inline comments.
app_templates/cpp/CMake/cmake_kdevplugin/README
17 ↗(On Diff #9280)

It really should be "add", but as you can see by the update the double "on" also confused me on second read, so had changed to: "on OS with xx bit system add". Does that work better?

35 ↗(On Diff #9280)

As you can see by my update I did while you were commenting on the initial version, I agree :)

This revision was automatically updated to reflect the committed changes.
kossebau marked an inline comment as done.