Remove KDEV_USE_EXTENSION_INTERFACE
ClosedPublic
Actions

Authored by kfunk on Dec 21 2016, 10:35 AM.

Details

Reviewers

Commits

R32:71b57dcade5d: Remove KDEV_USE_EXTENSION_INTERFACE
R33:71b57dcade5d: Remove KDEV_USE_EXTENSION_INTERFACE

Summary

This is actually not needed. All functionality we use is provided by the Qt meta object system.
There's one feature we loose: Listing the extensions of a plugin
(IPlugin::extensions()); which is never used however. I don't see it being overly useful either.

Simplifies plugin development a bit.

Diff Detail

Repository

R33 KDevPlatform

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

kfunk updated this revision to Diff 9250.Dec 21 2016, 10:35 AM

kfunk retitled this revision from to Remove KDEV_USE_EXTENSION_INTERFACE.

kfunk updated this object.

kfunk edited the test plan for this revision. (Show Details)

Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptDec 21 2016, 10:35 AM

Note: Unit tests still pass, KDevelop compiles fine with the change

Remove stale member, remove some more uses of KDEV_USE_EXTENSION_INTERFACE

apol accepted this revision.Dec 21 2016, 2:42 PM

apol added a reviewer: apol.

This revision is now accepted and ready to land.Dec 21 2016, 2:42 PM

Closed by commit R33:71b57dcade5d: Remove KDEV_USE_EXTENSION_INTERFACE (authored by kfunk). · Explain WhyDec 21 2016, 5:01 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			Architecture.dox (5 lines)
M			CMakeLists.txt (2 lines)
M			interfaces/iplugin.h (22 lines)
M			interfaces/iplugin.cpp (11 lines)
M			plugins/appwizard/appwizardplugin.cpp (1 line)
M			plugins/bazaar/bazaarplugin.cpp (3 lines)
M			plugins/contextbrowser/contextbrowser.cpp (2 lines)
M			plugins/cvs/cvsplugin.cpp (3 lines)
M			plugins/execute/executeplugin.cpp (1 line)
M			plugins/executescript/executescriptplugin.cpp (1 line)
M			plugins/filetemplates/filetemplatesplugin.cpp (1 line)
M			plugins/git/gitplugin.cpp (4 lines)
M			plugins/openwith/openwithplugin.cpp (1 line)
M			plugins/patchreview/patchreview.cpp (5 lines)
M			plugins/perforce/perforceplugin.cpp (4 lines)
M			plugins/projectfilter/projectfilterprovider.cpp (2 lines)
M			plugins/quickopen/quickopenplugin.cpp (1 line)
M			plugins/standardoutputview/standardoutputview.cpp (2 lines)
M			plugins/subversion/kdevsvnplugin.cpp (3 lines)
M			project/abstractfilemanagerplugin.cpp (2 lines)
M			shell/tests/nonguiinterfaceplugin.cpp (1 line)
M			shell/tests/test_plugincontroller.cpp (8 lines)
M			shell/tests/test_projectcontroller.cpp (5 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	9250	ca85cac		Dec 21 2016, 10:35 AM	★	★
Diff 2	9252	ca85cac	Remove stale member, remove some more uses of KDEV_USE_EXTENSION_INTERFACE	Dec 21 2016, 11:46 AM	★	★
Diff 3	9260	b308fa6	R33:71b57dcade5d8677495775b43299c2d4093c5719	Dec 21 2016, 12:11 PM	★	★

Remove KDEV_USE_EXTENSION_INTERFACEClosedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 9260

Architecture.dox

CMakeLists.txt

interfaces/iplugin.h

interfaces/iplugin.cpp

plugins/appwizard/appwizardplugin.cpp

plugins/bazaar/bazaarplugin.cpp

plugins/contextbrowser/contextbrowser.cpp

plugins/cvs/cvsplugin.cpp

plugins/execute/executeplugin.cpp

plugins/executescript/executescriptplugin.cpp

plugins/filetemplates/filetemplatesplugin.cpp

plugins/git/gitplugin.cpp

plugins/openwith/openwithplugin.cpp

plugins/patchreview/patchreview.cpp

plugins/perforce/perforceplugin.cpp

plugins/projectfilter/projectfilterprovider.cpp

plugins/quickopen/quickopenplugin.cpp

plugins/standardoutputview/standardoutputview.cpp

plugins/subversion/kdevsvnplugin.cpp

project/abstractfilemanagerplugin.cpp

shell/tests/nonguiinterfaceplugin.cpp

shell/tests/test_plugincontroller.cpp

shell/tests/test_projectcontroller.cpp

Remove KDEV_USE_EXTENSION_INTERFACE
ClosedPublic
Actions

Revision Contents
Changeset List