Add wlan access info to marble maps android application
ClosedPublic

Authored by spencerb on Dec 21 2016, 1:13 AM.

Diff Detail

Repository
R34 Marble
Lint
Lint Skipped
Unit
Unit Tests Skipped
spencerb updated this revision to Diff 9244.Dec 21 2016, 1:13 AM
spencerb retitled this revision from to Add wlan access info to marble maps android application.
spencerb updated this object.
spencerb edited the test plan for this revision. (Show Details)
spencerb added reviewers: Marble, nienhueser.
spencerb set the repository for this revision to R34 Marble.
spencerb added a project: Marble.
spencerb added a subscriber: rahn.
nienhueser requested changes to this revision.Dec 21 2016, 10:28 AM
nienhueser edited edge metadata.

Looks fine, but I'd like to cover some more tags, see the inline comment.

src/lib/marble/declarative/Placemark.cpp
227

Please update to latest master, these changes shouldn't be in here.

529

I'd like to include more tags so that we cover all commonly used tags:

  • If internet_access=no, note it.
  • Otherwise if internet_access=wlan, note that but change the wording to include internet_access:fee: If fee is no, write "free public", if fee is yes, write sth like "charged public" and if fee is not set, write "public"
  • Finally wifi=yes/no/free is in use as well, see https://taginfo.openstreetmap.org/keys/?key=wifi#values The same wording can re-used for it
This revision now requires changes to proceed.Dec 21 2016, 10:28 AM
spencerb updated this revision to Diff 9338.Dec 23 2016, 2:42 PM
spencerb edited edge metadata.
Closed by commit R34:b32c516fabbe: Add wlan access info (authored by Spencer Brown <sbrown124@gmail.com>, committed by nienhueser). · Explain WhyDec 23 2016, 3:48 PM
This revision was automatically updated to reflect the committed changes.