Extended SortedField with methods and a dptr
- R14:2209f06112fa: Add dptr to KReportData and SortedField
How about moving these docs to KReportDesign.h for the users?
Minor, for the future: it's enough to use new Private without ()
Equivalent of errorLineNumber() >= 0 && errorColumnNumber() >= 0.
And let's change implementation accordingly.
In case of methods that return by value non-const overload is not needed.
setErrorLineNumber (similar to what Qt uses in some XML or DOM APIs)
KReportDesignReadingStatus would benefit from a copy ctor and operator=. Actually it's not that hard as the Private class is easily copyable because all its members are values.
If we support KReportDesignReadingStatus::operator=() we could just do this here:
*status = KReportDesignReadingStatus();
And this would be more maintainable.
Good job. Almost there!
It's enough to call *this = other
missing && d->errorColumnNumber >= 0
Unrelated to the port but while we're at this: we're not setting message at all here or removing previous one. Note that the status object is supplied by the user so we don't know what it is.
Proposed solution: if d->processDocument(doc, status) fails, set error message to something like tr("Error in XML document.").
The return value needs to be KReportDesignReadingStatus&