Add dptr to classes in KReportRendererBase.h
ClosedPublic

Authored by piggz on Dec 19 2016, 9:43 PM.

Details

Summary

Added getters/setters to KReportRendererContext

Test Plan

Ensured screen renderer still works in kreportexample

Diff Detail

Repository
R14 KReport
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
piggz updated this revision to Diff 9191.Dec 19 2016, 9:43 PM
piggz retitled this revision from to Add dptr to classes in KReportRendererBase.h.
piggz updated this object.
piggz edited the test plan for this revision. (Show Details)
piggz added a reviewer: staniek.
Restricted Application added a project: KReport. · View Herald TranscriptDec 19 2016, 9:43 PM
staniek requested changes to this revision.Dec 19 2016, 9:53 PM
staniek edited edge metadata.
staniek added inline comments.
src/renderer/KReportRendererBase.cpp
35

I recommend start using C++11 init instead the painter(0), printer(0); simpler, less error-prone, ie.

QPainter *painter = nullptr;
QPrinter *printer = nullptr;
49–69

missing delete?

111

we're adding bool dummy = true; to fix build with some compilers

114

missing delete

src/renderer/KReportRendererBase.h
37

let's synchronize setter and getter, e.g. using url/setUrl

41

Our new convention so far was QPrinter *printer() and adding const QPrinter *printer() const too.

Same for painter().

src/renderer/KReportScreenRenderer_p.cpp
34–35

let's remove?

This revision now requires changes to proceed.Dec 19 2016, 9:53 PM
piggz updated this revision to Diff 9195.Dec 19 2016, 10:12 PM
piggz edited edge metadata.
piggz marked 6 inline comments as done.
  • Implement review comments
staniek accepted this revision.Dec 20 2016, 8:51 AM
staniek edited edge metadata.
This revision is now accepted and ready to land.Dec 20 2016, 8:51 AM
This revision was automatically updated to reflect the committed changes.