Added getters/setters to KReportRendererContext
Details
Details
- Reviewers
staniek - Commits
- R14:77732e2fb5d8: Add dptr to classes in KReportRendererBase.h
Ensured screen renderer still works in kreportexample
Diff Detail
Diff Detail
- Repository
- R14 KReport
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
src/renderer/KReportRendererBase.cpp | ||
---|---|---|
35 | I recommend start using C++11 init instead the painter(0), printer(0); simpler, less error-prone, ie. QPainter *painter = nullptr; QPrinter *printer = nullptr; | |
49–69 | missing delete? | |
111 | we're adding bool dummy = true; to fix build with some compilers | |
114 | missing delete | |
src/renderer/KReportRendererBase.h | ||
37 | let's synchronize setter and getter, e.g. using url/setUrl | |
41 | Our new convention so far was QPrinter *printer() and adding const QPrinter *printer() const too. Same for painter(). | |
src/renderer/KReportScreenRenderer_p.cpp | ||
34–35 | let's remove? |