Add dptr to KReportScriptHandler

Authored by piggz on Dec 19 2016, 6:42 PM.


Test Plan

Ran kreportexample and Kexi with a report containing scripts

Diff Detail

R14 KReport
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
piggz updated this revision to Diff 9177.Dec 19 2016, 6:42 PM
piggz retitled this revision from to Add dptr to KReportScriptHandler.
piggz updated this object.
piggz edited the test plan for this revision. (Show Details)
piggz added a reviewer: staniek.
Restricted Application added a project: KReport. · View Herald TranscriptDec 19 2016, 6:42 PM
staniek added inline comments.Dec 19 2016, 7:17 PM

How about putting all these 4 variables on stack in Private to simplify the code? Now they're leaked BTW.



staniek requested changes to this revision.Dec 19 2016, 7:17 PM
staniek edited edge metadata.
This revision now requires changes to proceed.Dec 19 2016, 7:17 PM
piggz updated this revision to Diff 9183.Dec 19 2016, 8:16 PM
piggz edited edge metadata.
  • Implement comments. Note, only engine is added to heap becuase it deletes registered objects.
piggz marked 2 inline comments as done.Dec 19 2016, 8:16 PM
staniek accepted this revision.Dec 19 2016, 8:35 PM
staniek edited edge metadata.

1 fix left, please land without further review, thanks.


Sorry, this note is not needed, I meant only the one from line 62. Thanks.

This revision is now accepted and ready to land.Dec 19 2016, 8:35 PM
This revision was automatically updated to reflect the committed changes.