Differential D3730

Fix build in out-of-source builds
ClosedPublic
Actions

Authored by tcanabrava on Dec 19 2016, 10:21 AM.

Details

Reviewers
kfunk
Commits
R218:085cbdaab049: Fix build in out-of-source builds
R32:085cbdaab049: Fix build in out-of-source builds
Summary

Code seemed right, but for some reason the folder path was empty:
[ 5%] Building CXX object CMakeFiles/kdevclangtidy.dir/src/plugin.cpp.o
/usr/bin/c++ -DKCOREADDONS_LIB -DQT_CORE_LIB -DQT_DBUS_LIB
-DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_NO_DEBUG -DQT_WIDGETS_LIB
-DQT_XML_LIB -D_GNU_SOURCE -D_LARGEFILE64_SOURCE -Dkdevclangtidy_EXPORTS
-I/home/tcanabrava/Projects/kdesrc/build/kdev-clang-tidy
-I/home/tcanabrava/Projects/kdesrc/kdev-clang-tidy -I/src

the -I/src should have been:

-I/home/tcanabrava/Projects/kdesrc/kdev-clang-tidy/src

my setup is:

Projects/sources/blah
Projects/builds/blah

Maybe the current way worked with inner build folders.

Signed-off-by: Tomaz Canabrava <tcanabrava@kde.org>

Diff Detail

Repository
R218 KDev Clang-Tidy Support
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
tcanabrava updated this revision to Diff 9151.Dec 19 2016, 10:21 AM
tcanabrava retitled this revision from to Fix build in out-of-source builds.
tcanabrava updated this object.
tcanabrava edited the test plan for this revision. (Show Details)
Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptDec 19 2016, 10:21 AM
kfunk accepted this revision.Dec 19 2016, 10:22 AM
kfunk added a reviewer: kfunk.
kfunk added a subscriber: kfunk.

Please use the CMAKE_CURRENT_FOO variants, then you can push directly

This revision is now accepted and ready to land.Dec 19 2016, 10:22 AM
Closed by commit R218:085cbdaab049: Fix build in out-of-source builds (authored by tcanabrava). · Explain WhyDec 19 2016, 10:28 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
MCMakeLists.txt (4 lines)

Diff 9152

View Options

CMakeLists.txt

Loading...