do not explicitly check NotShownIn it's not necessary and incomplete
ClosedPublic

Authored by sitter on Dec 16 2016, 12:39 PM.

Details

Summary

KService::noDisplay() includes qualification for

  • NoDisplay entry itself
  • OnlyShowIn and NotShowIn
  • X-KDE-OnlyShowOnQtPlatforms
  • authorization WRT KCMs

as such checking nodisplay is good enough to disqualify services in all
relevant scenarios

Test Plan
  • read the code of noDisplay()

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
sitter updated this revision to Diff 9080.Dec 16 2016, 12:39 PM
sitter retitled this revision from to do not explicitly check NotShownIn it's not necessary and incomplete.
sitter updated this object.
sitter edited the test plan for this revision. (Show Details)
sitter added a reviewer: broulik.
Restricted Application added a project: Plasma. · View Herald TranscriptDec 16 2016, 12:39 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik accepted this revision.Dec 16 2016, 1:24 PM
broulik edited edge metadata.
This revision is now accepted and ready to land.Dec 16 2016, 1:24 PM
This revision was automatically updated to reflect the committed changes.