This provides media controls on the lock screen including album art, track, and title names.
Details
Details
- Reviewers
mart graesslin - Group Reviewers
Plasma: Design Plasma - Commits
- R120:f32960cf3805: Add Media Controls on lock screen
What's to be done:
- Allow to disable this for privacy reasons
- Prints a couple of QML warnings when the player exits as the source goes away but since you cannot quit the player from here (and it still ends up hiding the controls then) isn't too bad
Album art, title, artist, controls
No album art, no artist, in this case the player name is shown instead
Diff Detail
Diff Detail
- Repository
- R120 Plasma Workspace
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
I can also reproduce the crash when running kscreenlocker_greet --testing
It crashes when the KActionCollection (that holds the actions for the global shortcuts) gets destroyed on teardown. By that time KGlobalAccel cleanup already happened, it then creates a new instance apparently and then crashes somewhere. Is this a DBus (lockup) issue maybe? I can't get a meaningful backtrace, though. It doesn't happen if I have it leak the KActionCollection.
Comment Actions
From my side it can go in even without the config option. Let's better integrate the new features early and add the config lateron