Downgrade required ECM version to 5.26
AbandonedPublic

Authored by cfeck on Dec 13 2016, 9:00 AM.

Details

Reviewers
vkrause
antlarr
Summary

ECM 5.29 is not really needed. syntax-highlighting builds fine with 5.26
and with more applications requiring syntax-highlighting, it's better to
be able to build it with an LTS KF5 version.

Test Plan

Diff Detail

Repository
R216 Syntax Highlighting
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
antlarr updated this revision to Diff 8963.Dec 13 2016, 9:00 AM
antlarr retitled this revision from to Downgrade required ECM version to 5.26.
antlarr updated this object.
antlarr edited the test plan for this revision. (Show Details)
antlarr edited the test plan for this revision. (Show Details)Dec 13 2016, 9:07 AM
antlarr updated this object.Dec 13 2016, 9:23 AM
antlarr edited the test plan for this revision. (Show Details)
vkrause edited edge metadata.Dec 13 2016, 9:23 AM

The change is fine with me (and 5.26 indeed still works), the problem I see is that the version bumps here happen automatically by the KF5 release scripts AFAIK, ie. this will be a very short-lived change.

The change is fine with me (and 5.26 indeed still works), the problem I see is that the version bumps here happen automatically by the KF5 release scripts AFAIK, ie. this will be a very short-lived change.

Oops, good point, can you tell me what script is that? Maybe it can be fixed there?
(btw, https://phabricator.kde.org/D3662 will probably suffer from the same problem)

Sorry, I don't know, dfaure runs this usually I think.

antlarr updated this revision to Diff 8965.Dec 13 2016, 9:59 AM
antlarr edited edge metadata.
  • Set the ECM dependency with a variable
cfeck commandeered this revision.Feb 9 2017, 12:38 AM
cfeck added a reviewer: antlarr.
Restricted Application added a project: Frameworks. · View Herald TranscriptFeb 9 2017, 12:38 AM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
cfeck abandoned this revision.Feb 9 2017, 12:38 AM