file_templates: Remove '#include "foo.moc"' footer
ClosedPublic
Actions

Authored by kfunk on Dec 12 2016, 11:49 PM.

Details

Reviewers

apol
dfaure

Commits

R32:4b3f07cb02a9: file_templates: Remove '#include "foo.moc"' footer

Summary

No longer necessary for the majority of use-cases (QMake, or modern
AUTOMOC-based CMake)

Diff Detail

Repository

R32 KDevelop

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

kfunk updated this revision to Diff 8956.Dec 12 2016, 11:49 PM

kfunk retitled this revision from to file_templates: Remove '#include "foo.moc"' footer.

kfunk updated this object.

kfunk edited the test plan for this revision. (Show Details)

Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptDec 12 2016, 11:49 PM

@dfaure Looking through a couple of the issues you've found earlier this year

apol accepted this revision.Dec 13 2016, 3:10 AM

apol added a reviewer: apol.

This revision is now accepted and ready to land.Dec 13 2016, 3:10 AM

Also it could be useful if we could get a test that generates and compiles these, to make sure these make some kind of sense...

In D3657#68427, @apol wrote:

Also it could be useful if we could get a test that generates and compiles these, to make sure these make some kind of sense...

Definitely, had the same thought while filing this patch...

Closed by commit R32:4b3f07cb02a9: file_templates: Remove '#include "foo.moc"' footer (authored by kfunk). · Explain WhyDec 13 2016, 6:54 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			file_templates/classes/qobject/class.cpp (1 line)
M			file_templates/testing/cpp_qtestlib/class.cpp (2 lines)
M			file_templates/testing/cpp_qtestlib_kde/class.cpp (2 lines)
M			file_templates/testing/cpp_qtestlib_kdevelop/class.cpp (2 lines)