Register AbstractTasksModel as uncreatable type.
ClosedPublic

Authored by hein on Dec 10 2016, 11:26 PM.

Details

Summary

This makes the AdditionalRoles enum available to Qt Quick. Useful for
calling data() TasksModel from inside QML, which uses AbstractTasksModel
roles but doesn't actually inherit from AbstractTasksModel.

The reason TasksModel doesn't inherit from AbstractTasksModel is
because it inherits from QSortFilterProxyModel, and it doesn't fly
to multiple-inherit from two QObject-derived classes. This is also
why AdditionalRoles can't be moved to AbstractTasksModelIface easily.

The VDG is working on tooltip changes that require this.

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
hein updated this revision to Diff 8918.Dec 10 2016, 11:26 PM
hein retitled this revision from to Register AbstractTasksModel as uncreatable type..
hein updated this object.
hein edited the test plan for this revision. (Show Details)
hein added reviewers: Plasma, davidedmundson, romangg.
hein added a subscriber: plasma-devel.
Restricted Application added a project: Plasma. · View Herald TranscriptDec 10 2016, 11:26 PM
hein updated this revision to Diff 8919.Dec 10 2016, 11:35 PM

Document reason via comment.

davidedmundson accepted this revision.Dec 11 2016, 12:50 AM
davidedmundson edited edge metadata.
This revision is now accepted and ready to land.Dec 11 2016, 12:50 AM
romangg accepted this revision.Dec 11 2016, 12:54 AM
romangg edited edge metadata.
This revision was automatically updated to reflect the committed changes.