| brauch |
Instance methods can be called via the class:
Class.method(instance, arg)
Self arguments are handled separately. With an explicit instance argument as in the example, its type was wrongly used for the next argument with all subsequent argtypes offset by one.
BUG: 369364
Simply skip such arguments where they exist.
Test method_explicit_self previously failed, now passes.
Test parent_constructor_arg_type previously failed.
Now it fails on the first run, but gets the correct type if reloading the document.
Probably related to https://bugs.kde.org/show_bug.cgi?id=306213
Other new tests passed already.
No test regressions.
| Lint Skipped |
| Unit Tests Skipped |
This is sort of a temporary patch-up.
To solve https://bugs.kde.org/show_bug.cgi?id=288089, we need to do almost the opposite, and determine the self argument type from calls.
Such a solution would do more harm than good right now, because unsure class-types produce useless or incomplete results in most operations, so I think this makes sense for the moment.
Held a readlock while calling visitNode(), which caused a repeat-locking failure in some unusual cases.
Release the lock earlier, and add a test that triggered that bug.
Looks good to me, another thing I wanted to look into for ages. Thanks! Let's see if anything breaks :)