Investigate warnings and fix them [2]
AbandonedPublic
Actions

Authored by Sergobot on Dec 8 2016, 9:15 PM.

Details

Reviewers

Summary

There are 2 warnings which were not fixed, you can find those in task comments.

Test Plan

Unit tests were passed

Repository

R33 KDevPlatform

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Sergobot retitled this revision from to Investigate warnings and fix them [2].

Sergobot updated this object.

Sergobot edited the test plan for this revision. (Show Details)

Sergobot added subscribers: kfunk, ematirov.

Here are explanations on why I didn't fix some warnings. Also, attached to the GCI task.

unresolved.txt416 BDownload

please use Q_ASSERT, otherwise lgtm

language/codecompletion/codecompletionhelper.cpp
53	I think this can simply be removed, view will always be valid. you could make it a `Q_ASSERT`
language/duchain/duchainutils.cpp
164	someone needs to add proper braces to this fugly function (separate patch)

This revision now requires changes to proceed.Feb 18 2017, 11:11 PM

			Path	Packages
M			language/backgroundparser/backgroundparser.cpp (5 lines)
M			language/codecompletion/codecompletionhelper.cpp (15 lines)
M			language/duchain/declaration.cpp (6 lines)
M			language/duchain/duchainutils.cpp (12 lines)
M			language/duchain/navigation/abstractdeclarationnavigationcontext.cpp (3 lines)
M			language/duchain/navigation/abstractincludenavigationcontext.cpp (22 lines)
M			plugins/contextbrowser/contextbrowserview.cpp (8 lines)
M			plugins/externalscript/externalscriptjob.cpp (2 lines)
M			plugins/quickopen/expandingtree/expandingwidgetmodel.cpp (12 lines)
M			util/dbus_socket_transformer/main.cpp (3 lines)