Improve Makefile highlighting
ClosedPublic

Authored by arichardson on Dec 8 2016, 4:15 PM.

Details

Summary

Adds code folding for conditionals and support for bmake features

This is a series of commits:

makefile.xml: Allow "+" in variable names

This is used in FreeBSD lib/Makefile:SUBDIR_DEPEND_libc++:= libcxxrt

makefile.xml: initial support for bmake

makefile.xml: highlight bmake variable modifiers

makefile.xml: highlight bmake conditional expressions

makefile.xml: increase version number

makefile.xml: add code folding for bmake .if/.elif/.endif

makefile.xml: allow multiline conditionals

makefile.xml: highlight numbers in bmake conditionals

makefile.xml: highlight intentifiers in bmake conditionals as variables

makefile.xml: add support for special bmake targets such as .PHONY

makefile.xml: add support for special bmake sources such as .WAIT

makefile.xml: Add missing highlight and folding for .else

makefile.xml: add support for bmake include statement

makefile.xml: add support for bmake .info .warning and .error

makefile.xml: highlight bmake .for/.endfor and add folding

makefile.xml: highlight the remaining bmake directives

makefile.xml: add folding to GNU make conditionals and updated test

also shared some common rules

Diff Detail

Repository
R216 Syntax Highlighting
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
arichardson updated this revision to Diff 8857.Dec 8 2016, 4:15 PM
arichardson retitled this revision from to Improve Makefile highlighting.
arichardson updated this object.
arichardson edited the test plan for this revision. (Show Details)
vkrause accepted this revision.Dec 10 2016, 11:18 AM
vkrause added a reviewer: vkrause.
This revision is now accepted and ready to land.Dec 10 2016, 11:18 AM
arichardson closed this revision.Dec 11 2016, 5:22 PM

Pushed to master

orgads added a subscriber: orgads.Feb 8 2017, 8:10 PM
orgads added inline comments.
data/syntax/makefile.xml
354

bmake_var_modifiers_noarg is not defined anywhere as a keyword list. Nor is bmake_var_modifiers_with_arg.

Is this intended?

orgads added inline comments.May 14 2017, 4:47 AM
data/syntax/makefile.xml
354

Ping?