Python Scripter Refactoring - 2
ClosedPublic

Authored by eliakinalmeida on Dec 7 2016, 12:13 AM.

Details

Summary

This commit is a replace of the previous commit with a more simple
structure, bugfixes and one new Action(without implementation).

  • The loader package was removed from the plugin. I don't need load another types of components in the UI. If necessary, the action will invoke a method to addWidget in the UILayout.
  • The widgets dependent of action will be found in the action<action name> package.
  • The Widget package was deleted.
  • The paths to the action classes was placed in the __init__.py of the actions package
  • loadComponents was replaced with loadActions in a more simple implementation.
  • The loaded action can be found in the actions collection in the UIController class.

#BUGFIX

  • initialize method including repeatedly the same actions
  • Bug when the action modules are renamed.

Fixes T4551

Ref T1625

Test Plan

You can set a path to QIcon in the RunAction class, I don't put the icon in the krita yet.

Diff Detail

Repository
R37 Krita
Branch
eliakinalmeida/T4551-interactive-python-scripting
Lint
No Linters Available
Unit
No Unit Test Coverage
eliakinalmeida retitled this revision from to Python Scripter Refactoring - 2.
eliakinalmeida edited the test plan for this revision. (Show Details)
eliakinalmeida updated this object.
eliakinalmeida edited the test plan for this revision. (Show Details)Dec 7 2016, 12:15 AM
eliakinalmeida added a reviewer: rempt.
eliakinalmeida added a subscriber: eliakinalmeida.
eliakinalmeida edited the test plan for this revision. (Show Details)Dec 7 2016, 12:19 AM
woltherav accepted this revision.Dec 7 2017, 3:07 PM
This revision is now accepted and ready to land.Dec 7 2017, 3:07 PM
woltherav closed this revision.Dec 7 2017, 3:07 PM

This was pushed :)