Remove KReportPosition and KReportSize. Port the Line item to QPointF and KProperty.
ClosedPublic
Actions

Authored by piggz on Dec 6 2016, 10:34 PM.

Details

Reviewers

staniek

Commits

Summary

Line does not currently display in the designer, but does display ok in the renderer.

Test Plan

Test items in kreportexample

Repository

R14 KReport

Branch

remove-size-pos

Lint

No Linters Available

Unit

No Unit Test Coverage

piggz retitled this revision from to Remove KReportPosition and KReportSize. Port the Line item to QPointF and KProperty..

piggz updated this object.

piggz edited the test plan for this revision. (Show Details)

piggz added a reviewer: staniek.

Remove unused properies. Fix the designer rendering. Fix incompatible property warning.

Works fine, thanks. Go ahead if we're sure the document format is not altered...

This revision is now accepted and ready to land.Dec 8 2016, 12:24 AM

This revision was automatically updated to reflect the committed changes.

		Path
M		autotests/format/FormatTest.cpp (2 lines)
M		src/CMakeLists.txt (4 lines)
M		src/common/KReportItemBase.h (3 lines)
M		src/common/KReportItemLine.h (9 lines)
M		src/common/KReportItemLine.cpp (36 lines)
D	M	src/common/KReportPosition.h (61 lines)
D	M	src/common/KReportPosition.cpp (101 lines)
D	M	src/common/KReportSize.h (56 lines)
D	M	src/common/KReportSize.cpp (96 lines)
M		src/common/KReportUtils.cpp (4 lines)
M		src/items/check/KReportItemCheck.h (2 lines)
M		src/items/check/KReportScriptCheck.cpp (3 lines)
M		src/items/field/KReportItemField.h (1 line)
M		src/items/field/KReportScriptField.cpp (4 lines)
M		src/items/image/KReportItemImage.h (2 lines)
M		src/items/label/KReportItemLabel.h (2 lines)
M		src/items/label/KReportScriptLabel.cpp (3 lines)
M		src/items/text/KReportItemText.h (2 lines)
M		src/items/text/KReportScriptText.cpp (3 lines)
M		src/plugins/maps/KReportItemMaps.h (2 lines)
M		src/plugins/web/KReportItemWeb.h (2 lines)
M		src/renderer/KReportAsyncItemManager_p.cpp (2 lines)
M		src/renderer/scripting/KReportScriptDraw.cpp (23 lines)
M		src/renderer/scripting/KReportScriptLine.cpp (8 lines)
M		src/wrtembed/KReportDesignerItemLine.cpp (31 lines)
M		src/wrtembed/KReportDesignerItemRectBase.cpp (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	8828	1b554d8		Dec 6 2016, 10:34 PM	★	★
Diff 2	8850	1b554d8	- Remove unused properies. Fix the designer rendering. Fix incompatible property warning.	Dec 7 2016, 8:02 PM	★	★
Diff 3	8866	1b554d8	R14:4e7e49cb2a105b1e56e751befb826edaa4c3fd8a	Dec 8 2016, 7:29 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
0df59e4b2096	0b12dfae2384	1b554d8e7547	Adam Pigg	Remove KReportPosition and KReportSize. Port the Line item to QPointF and… (Show More…)	Dec 6 2016, 10:33 PM