Add copy and sports shops to to Marble Vector OpenStreetMap
ClosedPublic

Authored by spencerb on Dec 6 2016, 3:22 PM.

Details

Summary

Added placemarks, icons, and tags for copyshops and sports shops.

Diff Detail

Repository
R34 Marble
Lint
Lint Skipped
Unit
Unit Tests Skipped
spencerb updated this revision to Diff 8811.Dec 6 2016, 3:22 PM
spencerb retitled this revision from to Add copy and sports shops to to Marble Vector OpenStreetMap.
spencerb updated this object.
spencerb edited the test plan for this revision. (Show Details)
spencerb added reviewers: rahn, nienhueser, Marble.
spencerb set the repository for this revision to R34 Marble.
spencerb added a project: Marble.
nienhueser requested changes to this revision.Dec 6 2016, 5:00 PM
nienhueser edited edge metadata.

Looks good, but please check the descriptions for the "no" parts in Placemark.cpp, some repeat the "yes" variant.

This revision now requires changes to proceed.Dec 6 2016, 5:00 PM
spencerb updated this revision to Diff 8819.Dec 6 2016, 6:36 PM
spencerb edited edge metadata.

Can you please check which branch you are running? It should be master and be a recent revision. The patch above does not apply to current master unfortunately.

src/lib/marble/declarative/Placemark.cpp
141 ↗(On Diff #8826)

Here "Photocopying service" should be "No photocopying service", same for the other no variants below. The first argument in the tr() call is what the end user sees, the second one is an aid to the translator.

142 ↗(On Diff #8826)

Please use consistent first-word capitalization: "Digital scanning" instead of "digitial scanning". Same for the next three lines.

nienhueser requested changes to this revision.Dec 6 2016, 6:59 PM
nienhueser edited edge metadata.
This revision now requires changes to proceed.Dec 6 2016, 6:59 PM

The branch is master, I cloned it yesterday. It looks about 5 commits behind, sorry.

spencerb updated this revision to Diff 8823.Dec 6 2016, 8:41 PM
spencerb edited edge metadata.

I think that should fix it.

nienhueser requested changes to this revision.Dec 6 2016, 9:20 PM
nienhueser edited edge metadata.

I think you uploaded the old diff again this time. It has not changed.

This revision now requires changes to proceed.Dec 6 2016, 9:20 PM
spencerb updated this revision to Diff 8826.Dec 6 2016, 10:31 PM
spencerb updated this revision to Diff 8827.
spencerb edited edge metadata.
spencerb edited edge metadata.
nienhueser accepted this revision.Dec 7 2016, 5:30 AM
nienhueser edited edge metadata.

Somehow the patch is reversed, but I can deal with that.

This revision is now accepted and ready to land.Dec 7 2016, 5:30 AM
Closed by commit R34:6bd4a388e717: Add copy and sports shops (authored by Spencer Brown <sbrown124@gmail.com>, committed by nienhueser). · Explain WhyDec 7 2016, 5:31 AM
This revision was automatically updated to reflect the committed changes.