Investigate warnings and fix them [3]
ClosedPublic

Authored by Sergobot on Dec 5 2016, 4:49 PM.

Diff Detail

Repository
R33 KDevPlatform
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Sergobot updated this revision to Diff 8776.Dec 5 2016, 4:49 PM
Sergobot retitled this revision from to Investigate warnings and fix them [3].
Sergobot updated this object.
Sergobot edited the test plan for this revision. (Show Details)
Sergobot added reviewers: kfunk, ematirov.
Sergobot added subscribers: kfunk, ematirov.
Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptDec 5 2016, 4:49 PM
ematirov added inline comments.Dec 5 2016, 5:19 PM
shell/mainwindow_p.cpp
323
  1. There is no need in moving this line
  2. "action = " part can be omitted since it's not used anyway.

But maybe it's better to keep it as it is since it doesn't hurt and do not create not very needed change in history. @kfunk?

util/tests/test_path.cpp
373 ↗(On Diff #8784)

Probably, this warning was false-positive warning since this one tests if equality overload is really working at all

vcs/vcspluginhelper.cpp
427

Not really necessary probably. @kfunk, same question?

kfunk requested changes to this revision.Dec 5 2016, 5:23 PM
kfunk edited edge metadata.

Rest LGTM

language/codecompletion/codecompletionitemgrouper.cpp
28–38

Style: While at it: Let's do one enum value per line?

shell/mainwindow_p.cpp
323

Please a) don't move the line, b) just omit action =. That's fine.

util/tests/test_path.cpp
373 ↗(On Diff #8784)

+1, don't remove these lines

@ematirov Is there a way to instruct PVS to ignore certain lines?

vcs/vcspluginhelper.cpp
427

Change looks good to me. I'd keep it.

This revision now requires changes to proceed.Dec 5 2016, 5:23 PM
Sergobot updated this revision to Diff 8782.Dec 5 2016, 6:08 PM
Sergobot edited edge metadata.
Sergobot marked 2 inline comments as done.

Fix issues

Sergobot updated this revision to Diff 8784.Dec 5 2016, 6:12 PM
Sergobot marked 3 inline comments as done.
Sergobot edited edge metadata.

Remove that little comment in util/tests/test_path.cpp

Sergobot updated this revision to Diff 8785.Dec 5 2016, 6:15 PM

Remove unneccessary new line in util/tests/test_path.cpp

Sergobot updated this revision to Diff 8790.Dec 5 2016, 6:28 PM
Sergobot marked 2 inline comments as done.

Remove all the remaining whitespaces

ematirov edited edge metadata.Dec 5 2016, 6:49 PM

LGTM, thanks.

kfunk added a comment.Dec 5 2016, 11:40 PM

LGTM, thanks!

I'll do some testing before pushing this though.

mwolff accepted this revision.Feb 18 2017, 11:07 PM
mwolff added a subscriber: mwolff.

Kevin, did you do the testing? can we merge this?

This revision was automatically updated to reflect the committed changes.