Improve key details dialog

Authored by dvratil on Dec 3 2016, 10:19 PM.



OpenPGP main view:

OpenPGP details:

S/MIME main view:

S/MIME CN details:

Diff Detail

R168 Kleopatra
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
dvratil updated this revision to Diff 8739.Dec 3 2016, 10:19 PM
dvratil retitled this revision from to Improve key details dialog.
dvratil updated this object.
dvratil edited the test plan for this revision. (Show Details)
dvratil added a reviewer: aheinecke.
dvratil set the repository for this revision to R168 Kleopatra.
dvratil added a subscriber: KDE PIM.
aheinecke edited edge metadata.Dec 5 2016, 2:29 PM

Ok I've tried it out and it's a nice start. I'm not sure if we should work on this as differential or commit and improve in master. From my point you can just commit if it makes things easier.

In general I'm missing the Web Of Trust view ( M56/145 )

In the User ID list:

  • I don't think TOFU info should be shown as a column, When TOFU is used it will affect validity. So we can but the TOFU Info if it is available in the tooltip for validity.
  • I'm missing the option to select and certify user id's.
  • I don't think Publishing works here as a checkbox (I know it was in the mock, sorry). It should better be a Button "Publish certificate" to upload the key on a keyserver.

(Btw. Key vs. Certificate, I hate that problem and While I'm more on the Key side we should be consistent with the rest.)

  • Publishing should only be shown for your own keys.

--> If a user certified user Id's we can show a question box "Do you also publish this certification for other people in the internet?" To determine if we should do lsign or sign+publish.

  • If I click on More details the button is disabled afterwards.

I also find Björns that the view is switched to the more details and web of trust view and you go back to the overview is nicer instead of showing them in popups.

dvratil updated this revision to Diff 9412.Dec 28 2016, 1:09 PM
dvratil edited edge metadata.
  • merge Laurent's changes from D3820
  • add "Certify ..." action for UIDs
  • improve tooltip behaviour
Restricted Application added a project: KDE PIM. · View Herald TranscriptDec 28 2016, 1:09 PM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
aheinecke accepted this revision.Jan 9 2017, 1:06 PM
aheinecke edited edge metadata.

Finally got around to testing this again. It's still missing the "Web of Trust" View, but that probably was unclear from the german mockups. It's the "User ID's and Certifications" that is currently in kleo. This page should show who has signed a key (gpg --list-sigs). ( ).
But I think you can push it now and we improve it in master before the next release. It's already a big improvement imo.

I have some visual nitpicks but I would do them directly in master once its committed.


This revision is now accepted and ready to land.Jan 9 2017, 1:06 PM
This revision was automatically updated to reflect the committed changes.