Warning fixes for GCI task.
Details
Diff Detail
- Repository
- R33 KDevPlatform
- Lint
Lint Skipped - Unit
Unit Tests Skipped
language/classmodel/documentclassesfolder.cpp | ||
---|---|---|
233 | Testing for CodeModelItem::Unknown makes no sense there since it's constant (0). Probably solutions are:
Probably first one will go but I'll prefer to hear @kfunk's opinion on that |
Thanks! Just some more nitpicks.
plugins/cvs/cvsproxy.cpp | ||
---|---|---|
188 | There are more such cases in cvsproxy.cpp. (Them are listed in file with warnings). Could you fix them too please? | |
plugins/quickopen/expandingtree/expandingdelegate.cpp | ||
134 | Please use "NotExpandable" there (and in other cases) instead of constant there since it's enum. The main idea of problem there is that order of values in enum can be changed, so NotExpandable will become no-zero and all these ifs will not work as expected. | |
plugins/testview/testview.cpp | ||
243 | Let's use just !stditemlist.IsEmpty() and stditemlist.first(). |
plugins/quickopen/expandingtree/expandingdelegate.cpp | ||
---|---|---|
134 | And that's one, please. It's really better to use enum by name and not by value. | |
plugins/testview/testview.cpp | ||
243 | It should be !itemsForProject.isEmpty(), not just itemsForProject.isEmpty(). Now it works like: |