Differential D358

Use KIconEngine to load icons
ClosedPublic
Actions

Authored by abrahams on Sep 17 2015, 4:22 PM.

Details

Reviewers
rempt
kossebau
Commits
R37:912aac8438a8: Use KIconEngine to load icons
R8:67a43dca3751: Use KIconEngine to load icons
Summary

This allows Qt to find icons in Windows without explicitly specifying KDE resource paths.

Diff Detail

Repository
R8 Calligra
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
abrahams updated this revision to Diff 889.Sep 17 2015, 4:22 PM
abrahams retitled this revision from to Use KIconEngine to load icons.
abrahams updated this object.
abrahams edited the test plan for this revision. (Show Details)
abrahams added reviewers: rempt, kossebau.
rempt accepted this revision.Sep 18 2015, 7:08 AM
rempt edited edge metadata.

That's interesting, one would have thought that fromTheme would be enough :-). In any case, please push. I'm still seriously considering putting our icons in a qrc file instead of a theme, though.

This revision is now accepted and ready to land.Sep 18 2015, 7:08 AM
abrahams added a comment.EditedSep 18 2015, 8:14 PM
In D358#7090, @rempt wrote:

That's interesting, one would have thought that fromTheme would be enough :-). In any case, please push. I'm still seriously considering putting our icons in a qrc file instead of a theme, though.

Yes, the problem seemed to be QIcon search path not including any KDE or Calligra directories... it might be interesting to check whether icons work correctly if installed to %localappdata% but this seems like a better solution for developing.

Closed by commit R8:67a43dca3751: Use KIconEngine to load icons (authored by abrahams). · Explain WhySep 18 2015, 8:20 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mlibs/widgets/KoIconUtils.cpp (9 lines)

Diff 899

View Options

libs/widgets/KoIconUtils.cpp

Loading...