Adds display of miniature golf courses in OSM
ClosedPublic

Authored by Rakete1111 on Dec 3 2016, 3:15 PM.

Details

Reviewers
nienhueser
Group Reviewers
Marble

Diff Detail

Repository
R34 Marble
Branch
minigolf (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Rakete1111 updated this revision to Diff 8722.Dec 3 2016, 3:15 PM
Rakete1111 retitled this revision from to Adds display of miniature golf courses in OSM.
Rakete1111 updated this object.
Rakete1111 edited the test plan for this revision. (Show Details)
nienhueser added a project: Marble.
nienhueser added a subscriber: Marble.
nienhueser requested changes to this revision.Dec 3 2016, 4:22 PM
nienhueser added a reviewer: nienhueser.
nienhueser added a subscriber: nienhueser.

Works fine once I add an entry for minigolf course in StyleBuilder::visualCategoryName(). Can you add that to the patch?

If you change CMAKE_BUILD_TYPE to Debug you find stuff like that easier. For this one it triggers an assertion in debug mode when starting marble and there is a missing category name.

This revision now requires changes to proceed.Dec 3 2016, 4:22 PM
Rakete1111 updated this revision to Diff 8726.Dec 3 2016, 4:45 PM
Rakete1111 edited edge metadata.

Added missing category name

I must have missed that one, sorry. Thanks, I will compile in Debug from now on :)

nienhueser accepted this revision.Dec 3 2016, 4:58 PM
nienhueser edited edge metadata.
This revision is now accepted and ready to land.Dec 3 2016, 4:58 PM
nienhueser closed this revision.Dec 3 2016, 10:36 PM

Submitted