Reduce code-duplication of socketpair in WaylandServer
ClosedPublic
Actions

Authored by graesslin on Dec 3 2016, 1:56 PM.

Details

Reviewers

Group Reviewers

Plasma on Wayland
KWin

Commits

Summary

WaylandServer creates a socketpair for several Wayland connections. So
far this duplicated code quite a bit.

This change introduces one method to perform the socketpair and the
error checking plus creating the server side ClientConnection from the
pair.

Test Plan

Tests still pass

Repository

R108 KWin

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

graesslin retitled this revision from to Reduce code-duplication of socketpair in WaylandServer.

graesslin updated this object.

graesslin edited the test plan for this revision. (Show Details)

Restricted Application added subscribers: kwin, plasma-devel. · View Herald Transcript

ping

hein added a reviewer: hein.

This revision is now accepted and ready to land.Dec 15 2016, 9:23 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			wayland_server.h (19 lines)
M			wayland_server.cpp (45 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	8719	7f16d83		Dec 3 2016, 1:56 PM	★	★
Diff 2	9111	1f5356e	R108:a7f5c1675425a81a955c1aac880706cb39b0b7ac	Dec 17 2016, 8:47 AM	★	★