Differential D3572

systemtray: Don't propagate unhandled wheel events
ClosedPublic
Actions

Authored by drosca on Dec 2 2016, 7:49 PM.

Details

Reviewers
mart
Group Reviewers
Plasma
Commits
R871:d1ea67c1fcf0: systemtray: Don't propagate unhandled wheel events
R120:d1ea67c1fcf0: systemtray: Don't propagate unhandled wheel events
Summary

Scrolling over empty space or applet that doesn't handle
wheel events no longer activates desktop containment actions.

Test Plan

Scrolling over applets that handles wheel events (sound, battery, ..)
still works. Scrolling in popup when there is a lot of hidden applets
works too.

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
drosca updated this revision to Diff 8704.Dec 2 2016, 7:49 PM
drosca retitled this revision from to systemtray: Don't propagate unhandled wheel events.
drosca updated this object.
drosca edited the test plan for this revision. (Show Details)
drosca added a reviewer: Plasma.
Restricted Application added a project: Plasma. · View Herald TranscriptDec 2 2016, 7:49 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart accepted this revision.Dec 5 2016, 9:41 AM
mart added a reviewer: mart.
mart added a subscriber: mart.

ok for this revision (in 5.8 as well) even tough it kinda masks the actual problem, that is the wheel containmentactions plugin sometimes loaded in still unknown circumstances

This revision is now accepted and ready to land.Dec 5 2016, 9:41 AM
Closed by commit R120:d1ea67c1fcf0: systemtray: Don't propagate unhandled wheel events (authored by drosca). · Explain WhyDec 6 2016, 11:07 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 8803

View Options

applets/systemtray/package/contents/ui/main.qml

Loading...