Differential D3568

Find the correct path to the cmake command
ClosedPublic
Actions

Authored by obogdan on Dec 2 2016, 10:48 AM.

Details

Reviewers
apol
kfunk
Group Reviewers
Frameworks
Commits
R240:e630aa985494: Find the correct path to the cmake command
Summary

When running tests with hardcoded cmake, it get's suffixed to the project's build path. Setting it with an absolute path ensures using the right cmake binary.

Test Plan

Compiled, installed. Used to generate tests for kdev-embedded. cmake binary is now prefixed with the absolute system path, and no longer with the project's build dir.

Diff Detail

Branch
find-cmake-binary
Lint
No Linters Available
Unit
No Unit Test Coverage
obogdan updated this revision to Diff 8694.Dec 2 2016, 10:48 AM
obogdan retitled this revision from to Find the correct path to the cmake command.
obogdan updated this object.
obogdan edited the test plan for this revision. (Show Details)
obogdan added a subscriber: kfunk.
kfunk accepted this revision.Dec 2 2016, 10:51 AM
kfunk added a reviewer: kfunk.

Makes sense to me (well, I proposed it!)

This revision is now accepted and ready to land.Dec 2 2016, 10:51 AM
apol accepted this revision.Dec 2 2016, 11:30 AM
apol added a reviewer: apol.
obogdan added a comment.Dec 2 2016, 11:30 AM

Should I wait for more people to review this?

ltoscano edited edge metadata.Dec 2 2016, 11:37 AM
ltoscano set the repository for this revision to R240 Extra CMake Modules.

Revision Contents
Changeset List

PathPackages
Mkde-modules/KDECMakeSettings.cmake (2 lines)

Diff 8694

View Options

kde-modules/KDECMakeSettings.cmake

Loading...