Hard-code krarc.protocol mimetypes that were recently removed from protocol
ClosedPublic
Actions

Authored by martinkostolny on Dec 1 2016, 11:07 PM.

Details

Reviewers

abika

Group Reviewers

Krusader

Commits

Summary

As I wrote in this comment: https://phabricator.kde.org/R167:e3fad5256a5cba9f908f1f5d951907c6194040b5#896867
...I'd like to propose hard-coding proven mimetypes now missing from krarc.protocol.

I know they can be manually configured in Konfigurator -> Protocols, but I believe this is more convenient for users.

Test Plan

Browse various archive files including epub, docx, war, ... and check (in address bar) that they are always opened with krarc.

Repository

R167 Krusader

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

martinkostolny retitled this revision from to Hard-code krarc.protocol mimetypes that were recently removed from protocol.

martinkostolny updated this object.

martinkostolny edited the test plan for this revision. (Show Details)

martinkostolny set the repository for this revision to R167 Krusader.

Just added another mime (application/vnd.rar) + code readability improved.

Ship it!

This revision is now accepted and ready to land.Dec 4 2016, 6:24 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			krusader/krservices.h (6 lines)
M			krusader/krservices.cpp (39 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	8689			Dec 1 2016, 11:00 PM	★	★
Diff 2	8733			Dec 3 2016, 5:38 PM	★	★
Diff 3	8755	101091f	R167:f57edb20c4fa4e53d6a245dcc81273b62e44f611	Dec 4 2016, 11:43 PM	★	★