Differential D3561

make the logic of PageRow a ListView
ClosedPublic
Actions

Authored by mart on Dec 1 2016, 3:26 PM.

Details

Reviewers
None
Group Reviewers
Kirigami
Commits
R169:7a6c6b9bcff9: make the logic of PageRow a ListView
Summary

it implements internally things like snapping and layouting
makes the qml code significantly simpler
it needs the columns stay the same size (as listview doesn't
correctly supports items of eterogeneous sizes)

Test Plan

tried the widget gallery on different styles, desktop and mobile

Diff Detail

Repository
R169 Kirigami
Branch
phab/listviewrow
Lint
No Linters Available
Unit
No Unit Test Coverage
mart updated this revision to Diff 8678.Dec 1 2016, 3:26 PM
mart retitled this revision from to make the logic of PageRow a ListView.
mart updated this object.
mart edited the test plan for this revision. (Show Details)
mart added a reviewer: Kirigami.
Restricted Application added a project: Kirigami. · View Herald TranscriptDec 1 2016, 3:26 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart updated this revision to Diff 8679.Dec 1 2016, 4:30 PM
  • refactor delegate of ApplicationHeader
mart updated this revision to Diff 8680.Dec 1 2016, 4:33 PM
  • remove some redundant properties
Closed by commit R169:7a6c6b9bcff9: make the logic of PageRow a ListView (authored by mart). · Explain WhyDec 2 2016, 11:06 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 8680

View Options

src/controls/ToolBarApplicationHeader.qml

Loading...
View Options

src/controls/templates/ApplicationHeader.qml

Loading...
View Options

src/controls/templates/private/PageRow.qml

Loading...