Differential D3535

Pass docstring into `docstringContainsHint()` rather than declaration.
ClosedPublic
Actions

Authored by flherne on Nov 29 2016, 12:52 AM.

Details

Reviewers
brauch
Commits
R53:9e9bcdc233f1: Pass docstring into `docstringContainsHint()` rather than declaration.
Summary

Getting the docstring first allows us to skip searching for hints when there isn't one.

(It's also more obvious what's happening).

Test Plan

No behaviour changes, no test regressions.

Diff Detail

Repository
R53 KDevelop: Python Support
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
flherne updated this revision to Diff 8581.Nov 29 2016, 12:52 AM
flherne retitled this revision from to Pass docstring into `docstringContainsHint()` rather than declaration..
flherne updated this object.
flherne edited the test plan for this revision. (Show Details)
flherne added a reviewer: brauch.
flherne set the repository for this revision to R53 KDevelop: Python Support.
Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptNov 29 2016, 12:52 AM
brauch accepted this revision.Nov 29 2016, 11:12 PM
brauch edited edge metadata.

Thanks, makes sense.

This revision is now accepted and ready to land.Nov 29 2016, 11:12 PM
Closed by commit R53:9e9bcdc233f1: Pass docstring into `docstringContainsHint()` rather than declaration. (authored by flherne). · Explain WhyNov 30 2016, 8:47 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 8624

View Options

duchain/declarationbuilder.cpp

Loading...
View Options

duchain/expressionvisitor.cpp

Loading...
View Options

duchain/helpers.h

Loading...