Differential D3534

Rename functionDeclarationForCalledDeclaration -> functionForCalled and tweak types.
ClosedPublic
Actions

Authored by flherne on Nov 29 2016, 12:44 AM.

Details

Reviewers

brauch

Commits

R53:d757d25e9638: Rename functionDeclarationForCalledDeclaration -> functionForCalled and tweak…

Summary

(unchanged from the one I linked on IRC)

Take a Declaration* instead of DeclarationPointer.

Returns struct { FunctionDeclaration* declaration, bool isConstructor } instead of QPair<FunctionDeclarationPointer, bool>.

Struct for readable attribute names rather than .first and .second.

Drop the magic pointer type because most callers only wrap a normal one for this call anyway.
^^^
Sanity-check? I don't see a need for them, and many other helper methods use normal pointers.

Test Plan

No test changes or regressions, no (intended) behaviour changes.
Tested on a couple of projects, didn't crash.

Diff Detail

Repository

R53 KDevelop: Python Support

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

flherne updated this revision to Diff 8579.Nov 29 2016, 12:44 AM

flherne retitled this revision from to Rename functionDeclarationForCalledDeclaration -> functionForCalled and tweak types..

flherne updated this object.

flherne edited the test plan for this revision. (Show Details)

flherne added a reviewer: brauch.

flherne set the repository for this revision to R53 KDevelop: Python Support.

Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptNov 29 2016, 12:44 AM

+1, as discussed on IRC -- replacing QPair is always good ;)

This revision is now accepted and ready to land.Nov 29 2016, 11:17 PM

Closed by commit R53:d757d25e9638: Rename functionDeclarationForCalledDeclaration -> functionForCalled and tweak… (authored by flherne). · Explain WhyNov 30 2016, 8:47 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			codecompletion/context.cpp (2 lines)
M			codecompletion/items/functiondeclaration.cpp (14 lines)
M			duchain/declarationbuilder.cpp (9 lines)
M			duchain/expressionvisitor.cpp (9 lines)
M			duchain/helpers.h (6 lines)
M			duchain/helpers.cpp (14 lines)
M			duchain/usebuilder.cpp (8 lines)