remove the timer that selects the index at startup that caused flickering and things moving around since index 0 got selected, then moved to the correct one only after a while. unfortunately there is not a place (a signal) that says "the view has been correctly instanced from the model" that would be where selecting the current index at startup would be the safest. a place that seems working correctly is on listview onCountChanged this has to introduce KCMLookandFeel::selectedPluginIndex that isn't very pretty, but the flickering seems to be gone and the kcm loads from the correct place of the view from the first frame is displayed
Details
Details
- Reviewers
davidedmundson - Group Reviewers
Plasma - Commits
- R119:ee2ec66a4155: Select correct index without timer
he flickering seems to be gone and the kcm loads from the correct place of the view from the first frame is displayed. Once this is in the final form, some other config dialogs need the same treatment: plasma theme and wallpapers
Diff Detail
Diff Detail
- Repository
- R119 Plasma Desktop
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Is this just a manifest of us populating the model in KCMLookandFeel::load which is after setSource?
Comment Actions
I tried to add a load() in kcmutils/KCModuleQml just before loading the qml file, but even in that case assigning currentIndex: in the declaration of the GridView but doesn't seem to be enough, the only place where it's working seems to be onCountChanged even in that case.
Same thing if i add load() in the l&f kcm constructor.