Details

Reviewers

staniek
piggz

Group Reviewers

KReport

Commits

R14:1dc3c3edd926: New: KReportAddQCH.cmake for creating an API dox QCH file during the build

Summary

Custom copy of upcoming ECMAddQCH.cmake, see https://phabricator.kde.org/D2854
for existing issues and open questions.

Test Plan

KReport.qch generated by this: https://share.kde.org/index.php/s/KmkOqGZV9jA6Jvf

Diff Detail

Repository

R14 KReport

Branch

addQCH

Lint

No Linters Available

Unit

No Unit Test Coverage

kossebau updated this revision to Diff 8533.Nov 26 2016, 1:06 PM

kossebau retitled this revision from to New: KReportAddQCH.cmake for creating an API dox QCH file during the build.

kossebau updated this object.

kossebau edited the test plan for this revision. (Show Details)

kossebau added reviewers: KReport, staniek, piggz.

kossebau added a project: KReport.

staniek requested changes to this revision.Nov 27 2016, 10:21 PM

staniek edited edge metadata.

staniek added inline comments.

CMakeLists.txt
23	ON by default? I am wondering about overhead.
src/CMakeLists.txt
335	Like in KProperty, side-by-sided install-ability would require using ${KREPORT_BASE_NAME}

This revision now requires changes to proceed.Nov 27 2016, 10:21 PM

use ${KREPORT_BASE_NAME} for the QCH OUTPUT_BASENAME argument

kossebau added inline comments.Nov 28 2016, 12:21 AM

CMakeLists.txt
23	See reply to same question here: https://phabricator.kde.org/D3514#inline-13770

staniek requested changes to this revision.Nov 28 2016, 8:10 AM

staniek edited edge metadata.

staniek added inline comments.

CMakeLists.txt
23	if @piggz agrees I propose default = OFF

This revision now requires changes to proceed.Nov 28 2016, 8:10 AM

apply all changes also done to the kproperty patch

workaround cmake_parse_arguments not defining variables for empty multi-var arguments

Looks good, thanks. Does it cleanly apply to master? I have marge conflics in src/CMakeLists.txt

Very good, thanks!

This revision is now accepted and ready to land.Nov 29 2016, 2:42 PM

Closed by commit R14:1dc3c3edd926: New: KReportAddQCH.cmake for creating an API dox QCH file during the build (authored by kossebau). · Explain WhyNov 29 2016, 2:54 PM

This revision was automatically updated to reflect the committed changes.

		Path
M		CMakeLists.txt (3 lines)
A	M	cmake/modules/KReportAddQCH.cmake (637 lines)
A	M	cmake/modules/KReportDoxygenQCH.config.in (236 lines)
A	M	cmake/modules/KReportDoxygenQCHLayout.xml (194 lines)
A	M	cmake/modules/KReportQueryQmake.cmake (57 lines)
M		src/CMakeLists.txt (35 lines)
M		src/KReportConfig.cmake.in (1 line)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	8533	fc47bb2		Nov 26 2016, 1:06 PM	★	★
Diff 2	8561	fc47bb2	use ${KREPORT_BASE_NAME} for the QCH OUTPUT_BASENAME argument	Nov 28 2016, 12:19 AM	★	★
Diff 3	8578	fc47bb2	apply all changes also done to the kproperty patch	Nov 28 2016, 8:42 PM	★	★
Diff 4	8585	fc47bb2	workaround cmake_parse_arguments not defining variables for empty multi-var arguments	Nov 29 2016, 1:01 AM	★	★
Diff 5	8603	fc47bb2	R14:1dc3c3edd926f813c4027fd7bdfaf8fd2df06a17	Nov 29 2016, 2:54 PM	★	★

New: KReportAddQCH.cmake for creating an API dox QCH file during the build
ClosedPublic
Actions

Details

Diff Detail

Revision Contents
Changeset List

Diff 8585

CMakeLists.txt

cmake/modules/KReportAddQCH.cmake

cmake/modules/KReportDoxygenQCH.config.in

cmake/modules/KReportDoxygenQCHLayout.xml

cmake/modules/KReportQueryQmake.cmake

src/CMakeLists.txt

src/KReportConfig.cmake.in

New: KReportAddQCH.cmake for creating an API dox QCH file during the buildClosedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 8585

CMakeLists.txt

cmake/modules/KReportAddQCH.cmake

cmake/modules/KReportDoxygenQCH.config.in

cmake/modules/KReportDoxygenQCHLayout.xml

cmake/modules/KReportQueryQmake.cmake

src/CMakeLists.txt

src/KReportConfig.cmake.in

New: KReportAddQCH.cmake for creating an API dox QCH file during the build
ClosedPublic
Actions

Revision Contents
Changeset List