New: KReportAddQCH.cmake for creating an API dox QCH file during the build
ClosedPublic

Authored by kossebau on Nov 26 2016, 1:06 PM.

Details

Summary

Custom copy of upcoming ECMAddQCH.cmake, see https://phabricator.kde.org/D2854
for existing issues and open questions.

Test Plan

Diff Detail

Repository
R14 KReport
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kossebau updated this revision to Diff 8533.Nov 26 2016, 1:06 PM
kossebau retitled this revision from to New: KReportAddQCH.cmake for creating an API dox QCH file during the build.
kossebau updated this object.
kossebau edited the test plan for this revision. (Show Details)
kossebau added reviewers: KReport, staniek, piggz.
kossebau added a project: KReport.
staniek requested changes to this revision.Nov 27 2016, 10:21 PM
staniek edited edge metadata.
staniek added inline comments.
CMakeLists.txt
23

ON by default? I am wondering about overhead.

src/CMakeLists.txt
335

Like in KProperty, side-by-sided install-ability would require using ${KREPORT_BASE_NAME}

This revision now requires changes to proceed.Nov 27 2016, 10:21 PM
kossebau updated this revision to Diff 8561.Nov 28 2016, 12:19 AM
kossebau edited edge metadata.

use ${KREPORT_BASE_NAME} for the QCH OUTPUT_BASENAME argument

kossebau added inline comments.Nov 28 2016, 12:21 AM
CMakeLists.txt
23

See reply to same question here: https://phabricator.kde.org/D3514#inline-13770

staniek requested changes to this revision.Nov 28 2016, 8:10 AM
staniek edited edge metadata.
staniek added inline comments.
CMakeLists.txt
23

if @piggz agrees I propose default = OFF

This revision now requires changes to proceed.Nov 28 2016, 8:10 AM
kossebau updated this revision to Diff 8578.Nov 28 2016, 8:42 PM
kossebau edited edge metadata.

apply all changes also done to the kproperty patch

kossebau updated this revision to Diff 8585.Nov 29 2016, 1:01 AM
kossebau edited edge metadata.

workaround cmake_parse_arguments not defining variables for empty multi-var arguments

Looks good, thanks. Does it cleanly apply to master? I have marge conflics in src/CMakeLists.txt

staniek accepted this revision.Nov 29 2016, 2:42 PM
staniek edited edge metadata.

Very good, thanks!

This revision is now accepted and ready to land.Nov 29 2016, 2:42 PM
This revision was automatically updated to reflect the committed changes.