Set m_client size in global compositor co-ordinates
ClosedPublic

Authored by davidedmundson on Nov 25 2016, 10:18 AM.

Details

Summary

KWin wants to deal with the post-scaled down client size, not the texture size.

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson retitled this revision from to Set m_client size in global compositor co-ordinates KWin wants to deal with the post-scaled down client size, not the texture size..
davidedmundson updated this object.
davidedmundson edited the test plan for this revision. (Show Details)
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: KWin. · View Herald TranscriptNov 25 2016, 10:18 AM
Restricted Application added subscribers: kwin, plasma-devel. · View Herald Transcript
graesslin added inline comments.
scene_qpainter.cpp
311–314

do you have a test case in another patch for this? If not I suggest to extend the scene qpainter test to verify the rendering is correct with different scaling

shell_client.cpp
403–405

why did you swap those two lines?

davidedmundson retitled this revision from Set m_client size in global compositor co-ordinates KWin wants to deal with the post-scaled down client size, not the texture size. to Set m_client size in global compositor co-ordinates.
davidedmundson updated this object.

Remove swapped lines

Restricted Application edited projects, added Plasma; removed KWin. · View Herald TranscriptDec 1 2016, 6:20 PM
davidedmundson marked 2 inline comments as done.Dec 1 2016, 6:24 PM
davidedmundson added inline comments.
scene_qpainter.cpp
311–314

I put a test with the QPainter commit which implicitly will also test this change.

graesslin accepted this revision.Dec 9 2016, 6:23 PM
graesslin added a reviewer: graesslin.
This revision is now accepted and ready to land.Dec 9 2016, 6:23 PM
This revision was automatically updated to reflect the committed changes.
davidedmundson marked an inline comment as done.