ChartShape: Fix crash due to accessing stale pointers
ClosedPublic

Authored by danders on Nov 22 2016, 1:01 PM.

Details

Summary

Some data pointers where not reset when shape selection changed,
thus accessing data from privously selected shape.

Test:
Add a chart to eg sheets
Undo
Add another shape to chart

Result before: crash
After: No crash

This may have bearing on:
CCBUG: 365238
but needs more testing.

Diff Detail

Repository
R8 Calligra
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
danders updated this revision to Diff 8397.Nov 22 2016, 1:01 PM
danders retitled this revision from to ChartShape: Fix crash due to accessing stale pointers.
danders updated this object.
danders added reviewers: boemann, mecir.
Restricted Application added projects: KEXI, Calligra: 3.0. · View Herald TranscriptNov 22 2016, 1:01 PM
boemann accepted this revision.Nov 22 2016, 7:11 PM
boemann edited edge metadata.
This revision is now accepted and ready to land.Nov 22 2016, 7:11 PM
This revision was automatically updated to reflect the committed changes.