Move linking to DL_LIBRARY to x11standalone platform
ClosedPublic
Actions

Authored by graesslin on Nov 22 2016, 7:38 AM.

Details

Reviewers

Group Reviewers

Plasma
KWin

Commits

R108:0dc500fe943f: Move linking to DL_LIBRARY to x11standalone platform

Summary

It's only needed by the GLX backend, so only find if we have GLX at all
and only link where needed. As it was handled incorrectly before, it's
now using proper ifdef.

Diff Detail

Repository

R108 KWin

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

graesslin updated this revision to Diff 8372.Nov 22 2016, 7:38 AM

graesslin retitled this revision from to Move linking to DL_LIBRARY to x11standalone platform.

graesslin updated this object.

graesslin edited the test plan for this revision. (Show Details)

graesslin added reviewers: KWin, Plasma.

Restricted Application added a project: KWin. · View Herald TranscriptNov 22 2016, 7:38 AM

Restricted Application added subscribers: kwin, plasma-devel. · View Herald Transcript

mart accepted this revision.Nov 22 2016, 9:16 AM

mart added a reviewer: mart.

This revision is now accepted and ready to land.Nov 22 2016, 9:16 AM

Closed by commit R108:0dc500fe943f: Move linking to DL_LIBRARY to x11standalone platform (authored by graesslin). · Explain WhyNov 22 2016, 1:22 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			CMakeLists.txt (13 lines)
M			libkwineffects/kwinconfig.h.cmake (1 line)
M			plugins/platforms/x11/standalone/CMakeLists.txt (4 lines)
M			plugins/platforms/x11/standalone/glxbackend.cpp (4 lines)